Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third seminar 과제 제출 #6
base: main
Are you sure you want to change the base?
Third seminar 과제 제출 #6
Changes from 1 commit
df2f546
8c2f0f7
fa60099
57b759d
42be135
43d41c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비즈니스 로직 예외를 발생시켜 정리했네용. 혹시
try caych
문으로 에러를 발생~처리를 하지 않는 이유는 무엇인지 궁금해요There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나도 수화 코멘트 보고 생각해봤는데, @RestControllerAdvice가 붙은 클래스에서 어짜피 처리해주기 때문인가? 어떻게 생각하는지 궁금해!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 BusinessException은 관련 ErrorStatus 내용을 담은 Dto를 response해주는 식으로 균일하게 처리할 건데, 매번 똑같은 로직을 try-catch로 잡아서 처리해주는 것보다는 @RestControllerAdvice가 붙은 클래스에서 전역적으로 한 번에 처리 해 줄려고!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orElseThrow 로 바로 날리는 방법도 있는 거 알아갑니다..!