Feedback ontology loading #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `packages/apollo-mst/src/AnnotationFeatureModel.ts` we set the session onject to type `any` and ignore the warnings and ignore warning Add test file so_types.gff3 with unconventional types.
* The UI shows the job as still in progress even after the importing is done. This is because (?) we don't have a `jobsManager.done(job)` in packages/jbrowse-plugin-apollo/src/session/ClientDataStore.ts * We should show how far we are from completing the file import.
|
@dariober I think I've fixed the issue where the ontology was always loaded in the test. The |
|
@shashankbrgowda This PR should notify the user that an ontology (sequence or gene ontology) is being loaded. It should show a progress bar in the "Running job" window (see screenshot below). If the ontology is already loaded then nothing should appear.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.