Skip to content

Commit

Permalink
Update to log4j 2.19.0 (#2654)
Browse files Browse the repository at this point in the history
* Remove log4j from grails

* Updates

* Try update

* Remove export plugin from instructor report

* Add back audit-logging

* Specify Ubuntu 20 on github workflow

Co-authored-by: Garrett Stevens <[email protected]>
  • Loading branch information
cmdcolin and garrettjstevens authored Jan 3, 2023
1 parent d6751dc commit 672a90a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/python-apollo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
test-python-apollo:
name: test-python-apollo

runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.8.7]
Expand Down Expand Up @@ -84,5 +84,3 @@ jobs:
key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
8 changes: 6 additions & 2 deletions grails-app/conf/BuildConfig.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ grails.project.dependency.resolution = {
inherits("global") {
// specify dependency exclusions here; for example, uncomment this to disable ehcache:
// excludes 'ehcache'
excludes "grails-plugin-log4j", "grails-plugin-logging", "log4j"
}

log "error" // log level of Ivy resolver, either 'error', 'warn', 'info', 'debug' or 'verbose'
checksums true // whether to verify checksums on resolve
legacyResolve false
// whether to do a secondary resolve on plugin installation, not advised and here for backwards compatibility
Expand All @@ -67,6 +67,11 @@ grails.project.dependency.resolution = {
}

dependencies {


runtime 'org.apache.logging.log4j:log4j-api:2.19.0'
runtime 'org.apache.logging.log4j:log4j-core:2.19.0'
runtime 'org.apache.logging.log4j:log4j-1.2-api:2.19.0'
// specify dependencies here under either 'build', 'compile', 'runtime', 'test' or 'provided' scopes e.g.
runtime 'mysql:mysql-connector-java:5.1.29'
runtime 'org.postgresql:postgresql:9.4.1212'
Expand Down Expand Up @@ -162,7 +167,6 @@ grails.project.dependency.resolution = {
//}
compile ":yammer-metrics:3.0.1-2"
compile "org.grails.plugins:quartz2:2.1.6.2"
compile "org.grails.plugins:export:1.6"

//compile ":joda-time:1.4"
// TODO: re-add when ready to install functional tests
Expand Down
3 changes: 0 additions & 3 deletions grails-app/views/annotator/instructorReport.gsp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<html>
<head>
<meta name="layout" content="report">
<export:resource />
<title>Annotators</title>

<script>
Expand Down Expand Up @@ -34,8 +33,6 @@
<div class="groupHeader">
<p>Group: ${userGroup.name}</p>
</div>
<p><export:formats formats="['csv', 'excel', 'xml']" action="export" params="[userGroups: userGroup.id]"> </export:formats>
</p>

<table class="reportTable">
<thead>
Expand Down

0 comments on commit 672a90a

Please sign in to comment.