Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exposure_category.csv #256

Open
wants to merge 7 commits into
base: 0.3-dev
Choose a base branch
from
Open

Conversation

stufraser1
Copy link
Member

@stufraser1 stufraser1 commented Sep 21, 2023

Suggestion to include indicator of economic value (e.g. GDP) and social(+economic) development (e.g. HDI) into exposure_category codelist - this is a gap that surfaced when adding some GFDRR exposure data (R5 project):
economic_indicator,Economic Indicator,"Economic activity and growth, including measures of economic value such as Gross Domestic Product (GDP)."
development_index,Development Index,"Social development, or social and economic development, such as the Human Development Index (HDI)."

Codelist metric_dimension then requires an index value - suggestion made:
indicator_index_value,Indicator or index value,"Value of economic indicator or development index."

Codelist quantity_kind has no corresponding value to use with exposure that includes a unitless index value, such as HDI: how to address this in the required field?

Merge checklist

If you added, removed or renamed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md
  • Update the diagrams in reference/schema/md
  • Update the JSON files in examples

Always:

  • Run ./manage.py pre-commit
  • Update the changelog (style guide)

Having trouble?

See how to resolve check failures.

Suggestion to include indicator of economic value (e.g. GDP) and social(+economic) development (e.g. HDI) into exposure category codelist - this is a gap that surfaced when adding some GFDRR exposure data (R5 project)
delete codelists> csv directory (superceded by schema > codelists > open / closed)
adding `indicator_index_value` to be used with new exposure_category `economic_indicator` and 
`development_index`
@odscjen
Copy link
Contributor

odscjen commented Sep 22, 2023

Just dipping in here to say the reason the test are failing is an issue with the CSV file. If you click on 'Details' to the right of "Run all tests/test (push)" and scroll up to "warnings summary" it'll show you what it thinks the CSV should look like. In this case you've put quotation marks around the final sentence (Value of economic indicator or development index.) but it doesn't need them as there are no special characters in the sentence.

Adding cm unit to IMT.csv for flood depth
1. Updating to include Rockfall kinetic energy, spectral acceleration at specific common periods, and inundation depth above floor level (useful in vulnerability curves).
2. On water depth, renamed as inundation depth and removed specific reference to flood or tsunami, so both hazards can use the same indundation depth metric. Removing duplication
3. On flow velocity removed specific reference to flood, landslide or tsunami, so all hazards can use the same indundation depth metric and extended the description to make it relevant to use on all fluid flows. Removing duplication
1. revise 'downtime' to the more formal 'disruption'
2. include number of days people can be displaced (adding to number of people displaced)
3. separated out casualty and fatality count, ratio for clearer definition
Add commercial licence explicitly. Open list, so other custom licences can be added for specific use cases.
Copy link
Contributor

@matamadio matamadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my knowledge, why is there "Content,data" instead of Data like in other rows?

Copy link
Contributor

@matamadio matamadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice additions.
Good to have distinctions between casualties and fatalities and disruption in terms of time and monetary.

@stufraser1
Copy link
Member Author

stufraser1 commented Apr 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants