Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codeslist to snake_case formatting #164

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Jul 28, 2023

Related issues

closes #153

Description

Geometry_type.csv has not been updated as the camelcase codes are also the way the actual names of the codes are written.

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit

If you added or removed a field:

  • Update the collapse option of the jsonschema directives for dataset, resource, hazard, exposure, vulnerability and loss on reference/schema.md

Having trouble?

See how to resolve check failures.

Copy link
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a changelog entry. Otherwise, looks good.

@odscjen odscjen requested review from stufraser1 and matamadio and removed request for odscrachel August 3, 2023 11:50
@odscjen odscjen merged commit e73c502 into dev Aug 3, 2023
4 checks passed
@odscjen odscjen deleted the codelist_snake_case branch August 3, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Codelists] Review codelists to ensure consistency of pattern, use snake_case rather than camelCase.
3 participants