Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v2.3.0 #298

Merged
merged 13 commits into from
Jan 16, 2025
Merged

Feature/v2.3.0 #298

merged 13 commits into from
Jan 16, 2025

Conversation

acollow
Copy link
Contributor

@acollow acollow commented Jan 15, 2025

This is an update to the main branch of GOCART to bring it in line and up to date with the GCM releases for MERRA-21C and v11, and to be tagged as GOCART v2.3.0. The changes include a fix for ozone replay, updating cmake to all for GOCART to be stand alone, revised extdata.yaml files to account for the seasonal cycle revision to the 2021 CEDS release, and an update to variable long names in the StateSpecs.rc file. Note that the changes for CEDS emissions requires this to be taken along with an update to GEOSchem_GridComp as achem also uses these emissions (GEOS-ESM/GEOSchem_GridComp#279).

Copy link

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@acollow acollow added Non 0-diff The changes in this pull request are non-zero-diff Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Jan 15, 2025
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, Non 0-diff

1 similar comment
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, Non 0-diff

Updated MAPL to latest used by GEOSadas
Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, Non 0-diff

Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, Non 0-diff

Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, Non 0-diff

Copy link

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: Contingent - DNA, Non 0-diff

@mathomp4
Copy link
Member

I've updated this PR to be sort of a mix of sdr_v2.3.0, develop, and #296 .

Mainly, the CI was out of date as was some of the CMakeLists.txt

@acollow acollow removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Jan 16, 2025
@acollow acollow marked this pull request as ready for review January 16, 2025 15:35
@acollow acollow requested review from amdasilva and a team as code owners January 16, 2025 15:35
@acollow
Copy link
Contributor Author

acollow commented Jan 16, 2025

I confirmed that these changes will build with the latest version of the GCM and ran a c24 AMIP for a few time steps to ensure that files are getting written out with the correct long names and the appropriate CEDS emissions are getting used (/discover/nobackup/acollow/c24_g2.3.0).

@mathomp4
Copy link
Member

NOTE to @amdasilva or @vbuchard, we'd want to update the date-of-release in CHANGELOG.md when this is released. Just for niceness.

Copy link
Collaborator

@vbuchard vbuchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks

@vbuchard vbuchard merged commit b41af1f into main Jan 16, 2025
7 of 11 checks passed
@mathomp4 mathomp4 deleted the feature/v2.3.0 branch January 16, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants