Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESMF CMake target to ESMF::ESMF #286

Merged
merged 6 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Modified the file paths in carbon, sulfate, and nitrate ExtData.yaml files to used the revised version of the CEDS anthropogenic emissions. Note the previous version has an incorrect seasonal cycle.


### Fixed

- Use 'CA' component name to identify carbonaceous contributions to PM in UFS diagnostic calculations. These contributions were missing due to changes in field names.
Expand All @@ -27,15 +28,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Required attributes for the 2D GOCART export fields in AERO_DP bundle have been set in subroutine append_to_bundle in Chem_AeroGeneric.F90. These export fields are imported by OBIO via Surface GC, and the missing of the attributes was causing the writing of surface import checkpoint to fail. The issue has been explained in detail on https://github.com/GEOS-ESM/GOCART/issues/258

- Additional tuning parameters for the soil moisture and drylimit calculations for application specific tuning.
- Required attributes for the 2D GOCART export fields in AERO_DP bundle have been set in subroutine append_to_bundle in Chem_AeroGeneric.F90. These export fields are imported by OBIO via Surface GC, and the missing of the attributes was causing the writing of surface import checkpoint to fail. The issue has been explained in detail on https://github.com/GEOS-ESM/GOCART/issues/258

- Added export line to GOCART2G_GridCompMod to couple allow use of GOCART
SU sulfate production tendency elsewhere in Chemistry, specifically for
CARMA

## [2.1.2] - 2022-10-07
- Update ESMF CMake target to `ESMF::ESMF`

- Changed SU2G_instance_SU.rc to now have separate filename inputs for explosive and degassing volcanoes
- Moved present volcanic emission inventories to one or the other line for these new entries; set other
Expand All @@ -47,12 +47,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
one or the other emission diagnostics (explosive or degassing).

- Changed Chem_SettlingSimple in the process library to call Mie Query for radius and rhop inputs to the settling velocity calculation. The calls to Chem_SettlingSimple were then changed accordingly in each of the species' grid comps. Since the RH flag is no longer needed, it was removed from GA_EnvironmentMod.F90 and each of the instance RC files.


- State Spec RC files for GOCART2G, CA, DU, NI, SU, and SS were updated such that the long names for AOD are more intuitive

- Modified ExtData.yaml files to persist as climatological anthropogenic emissions after the end of the CEDS dataset in 2019. Analogous rc files removed as this capability is only available with ExtData2G

- Update `components.yaml` to match that of GEOSgcm v11.6.1
- ESMA_env v4.29.0 (Baselibs 7.24.0, Updates for SLES15 at NCCS, various fixes)
- ESMA_cmake v3.48.0 (Fixes for NAS, debug flags, Updates for SLES15 at NCCS, MPI detection, ESMF and MPI CMake fixes for Spack)
Expand All @@ -62,7 +58,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Correct soil moisture parameterization in FENGSHA
- Add `soil_moisture_factor` to the DU2G_instance_DU.rc (same name used in the K14 scheme) and DU2G_GridCompMod.F90 files for FENGSHA
- Add `soil_drylimit_factor` to the DU2G_instance_DU.rc and DU2G_GridCompMod.F90 files for FENGSHA

- Moved process library macros to header file.

## [v2.2.1] - 2023-05-30
Expand Down
2 changes: 1 addition & 1 deletion ESMF/Aerosol_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ if (EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/Aerosol_GridComp.F90)

esma_add_library (${this}
SRCS Aerosol_GridComp.F90
DEPENDENCIES GOCART2G_GridComp MAPL esmf)
DEPENDENCIES GOCART2G_GridComp MAPL ESMF::ESMF)

mapl_acg (${this} Aerosol_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
Expand Down
10 changes: 5 additions & 5 deletions ESMF/Apps/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
esma_set_this ()

set (srcs
GOCART2G_SimpleBundleMod.F90
GOCART2G_SimpleBundleMod.F90
aop_calculator.F90
GOCART2G_AopMod.F90
)
Expand All @@ -18,10 +18,10 @@ endforeach ()
set (resource_files
aop_calculator.rc
)
install( FILES ${resource_files}
install( FILES ${resource_files}
DESTINATION etc
)
esma_add_library(${this}
SRCS ${srcs}
DEPENDENCIES MAPL Process_Library esmf NetCDF::NetCDF_Fortran
esma_add_library(${this}
SRCS ${srcs}
DEPENDENCIES MAPL Process_Library ESMF::ESMF NetCDF::NetCDF_Fortran
)
6 changes: 3 additions & 3 deletions ESMF/GOCART2G_GridComp/CA2G_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES MAPL GA_Environment Chem_Shared2G Process_Library esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES MAPL GA_Environment Chem_Shared2G Process_Library ESMF::ESMF NetCDF::NetCDF_Fortran)

mapl_acg (${this} CA2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
mapl_acg (${this} CA2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
GET_POINTERS DECLARE_POINTERS)

file (GLOB_RECURSE rc_files CONFIGURE_DEPENDS RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.rc *.yaml)
Expand Down
6 changes: 3 additions & 3 deletions ESMF/GOCART2G_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ set (srcs

set (resource_files
GOCART2G_GridComp.rc
)
)

install( FILES ${resource_files}
install( FILES ${resource_files}
DESTINATION etc
)

set (dependencies MAPL Chem_Shared2G Process_Library esmf)
set (dependencies MAPL Chem_Shared2G Process_Library ESMF::ESMF)
esma_add_library (${this}
SRCS ${srcs}
SUBCOMPONENTS ${alldirs}
Expand Down
6 changes: 3 additions & 3 deletions ESMF/GOCART2G_GridComp/DU2G_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES GA_Environment MAPL Chem_Shared2G Process_Library esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES GA_Environment MAPL Chem_Shared2G Process_Library ESMF::ESMF NetCDF::NetCDF_Fortran)

mapl_acg (${this} DU2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
mapl_acg (${this} DU2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
GET_POINTERS DECLARE_POINTERS)

file (GLOB_RECURSE rc_files CONFIGURE_DEPENDS RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.rc *.yaml)
Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART2G_GridComp/GA_Environment/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES MAPL Chem_Shared2G Process_Library esmf
DEPENDENCIES MAPL Chem_Shared2G Process_Library ESMF::ESMF
)

# CMake has an OpenMP issue with NAG Fortran: https://gitlab.kitware.com/cmake/cmake/-/issues/21280
Expand Down
6 changes: 3 additions & 3 deletions ESMF/GOCART2G_GridComp/NI2G_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES GA_Environment MAPL Chem_Shared2G Process_Library esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES GA_Environment MAPL Chem_Shared2G Process_Library ESMF::ESMF NetCDF::NetCDF_Fortran)

mapl_acg (${this} NI2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
mapl_acg (${this} NI2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
GET_POINTERS DECLARE_POINTERS)

file (GLOB_RECURSE rc_files CONFIGURE_DEPENDS RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.rc *.yaml)
Expand Down
6 changes: 3 additions & 3 deletions ESMF/GOCART2G_GridComp/SS2G_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES MAPL GA_Environment Chem_Shared2G Process_Library esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES MAPL GA_Environment Chem_Shared2G Process_Library ESMF::ESMF NetCDF::NetCDF_Fortran)

mapl_acg (${this} SS2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
mapl_acg (${this} SS2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
GET_POINTERS DECLARE_POINTERS)

file (GLOB_RECURSE rc_files CONFIGURE_DEPENDS RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.rc *.yaml)
Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART2G_GridComp/SU2G_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES GA_Environment MAPL Chem_Shared2G Process_Library esmf)
DEPENDENCIES GA_Environment MAPL Chem_Shared2G Process_Library ESMF::ESMF)

mapl_acg (${this} SU2G_StateSpecs.rc
IMPORT_SPECS EXPORT_SPECS INTERNAL_SPECS
Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART_GridComp/CFC_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 ESMF::ESMF NetCDF::NetCDF_Fortran)

esma_generate_gocart_code (${this} "-B\;-C\;-N\;GOCART")

Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ install( FILES ${resource_files}
DESTINATION etc
)

set (dependencies Chem_Base Chem_Shared MAPL GMAO_mpeu esmf)
set (dependencies Chem_Base Chem_Shared MAPL GMAO_mpeu ESMF::ESMF)
esma_add_library (${this}
SRCS ${srcs}
SUBCOMPONENTS ${alldirs}
Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART_GridComp/CO2_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 ESMF::ESMF NetCDF::NetCDF_Fortran)

esma_generate_gocart_code (${this} "-B\;-C\;-N\;GOCART")

Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART_GridComp/CO_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 ESMF::ESMF NetCDF::NetCDF_Fortran)

esma_generate_gocart_code (${this} "-B\;-E\;-F\;-N\;GOCART")

Expand Down
2 changes: 1 addition & 1 deletion ESMF/GOCART_GridComp/Rn_GridComp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ esma_set_this ()

esma_add_library (${this}
SRCS ${this}Mod.F90
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 esmf NetCDF::NetCDF_Fortran)
DEPENDENCIES Chem_Shared Chem_Base GMAO_mpeu MAPL_cfio_r4 ESMF::ESMF NetCDF::NetCDF_Fortran)

esma_generate_gocart_code (${this} "-B\;-E\;-F\;-N\;GOCART")

Expand Down
2 changes: 1 addition & 1 deletion ESMF/Shared/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set (srcs

esma_add_library(${this}
SRCS ${srcs}
DEPENDENCIES MAPL esmf)
DEPENDENCIES MAPL ESMF::ESMF)

if( EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/@GSW )
set (gsw_ECBUILD_SYSTEM_INCLUDED TRUE)
Expand Down
2 changes: 1 addition & 1 deletion ESMF/UFS/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ set (srcs
Aerosol_Tracer_Mod.F90
)

set (dependencies Aerosol_GridComp MAPL esmf)
set (dependencies Aerosol_GridComp MAPL ESMF::ESMF)
esma_add_library (${this}
SRCS ${srcs}
DEPENDENCIES ${dependencies})
6 changes: 3 additions & 3 deletions Process_Library/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ set (srcs
GOCART2G_Process.F90
)

esma_add_library(${this}
SRCS ${srcs}
DEPENDENCIES esmf NetCDF::NetCDF_Fortran
esma_add_library(${this}
SRCS ${srcs}
DEPENDENCIES ESMF::ESMF NetCDF::NetCDF_Fortran
)

# CMake has an OpenMP issue with NAG Fortran: https://gitlab.kitware.com/cmake/cmake/-/issues/21280
Expand Down
Loading