Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GMAO_perllib into its own repo #310

Closed
wants to merge 1 commit into from
Closed

Remove GMAO_perllib into its own repo #310

wants to merge 1 commit into from

Conversation

mathomp4
Copy link
Member

This PR removes GMAO_perllib into its own repo.

Requires a new GMAO_Shared as well: GEOS-ESM/GMAO_Shared#361

@mathomp4 mathomp4 added 0 diff structural Structural changes to repository that are zero-diff Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Nov 21, 2024
@github-actions GitHub Actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

1 similar comment
@github-actions GitHub Actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

rtodling
rtodling approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - w/o looking at what's in perllib and shared - the changes in the fixture of adas look good.

@rtodling rtodling marked this pull request as ready for review November 25, 2024 17:08
@rtodling rtodling requested a review from a team as a code owner November 25, 2024 17:08
@rtodling rtodling mentioned this pull request Nov 28, 2024
Merged
rtodling
rtodling reviewed Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think became obsolete @mathomp4 - I introduced this into what I had that had other changes ... based on what you did here. Perhaps we can close this?

@mathomp4
Copy link
Member Author

I think became obsolete @mathomp4 - I introduced this into what I had that had other changes ... based on what you did here. Perhaps we can close this?

Oh yeah. I guess so. Closing.

@mathomp4 mathomp4 closed this Jan 26, 2025
@mathomp4 mathomp4 deleted the feature/mathomp4/remove-perllib branch January 26, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtodling rtodling rtodling approved these changes

Assignees
No one assigned
Labels
0 diff structural Structural changes to repository that are zero-diff Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @rtodling