[Feat] #257 - textField Builder 구현 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongmin221
reviewed
Jun 21, 2024
| .build() | ||
| } | ||
|
|
||
| static func buildSerachTetField() -> UITextField { |
seongmin221
reviewed
Jun 21, 2024
Comment on lines
15
to
19
| .setLeftViewRect(forInsets: .init(top: 0, | ||
| left: 15, | ||
| bottom: 0, | ||
| right: -15) | ||
| ) |
There was a problem hiding this comment.
p4:
요거 한 줄로 해도 되지 않을까욤 ??
seongmin221
approved these changes
Jun 21, 2024
jeongdung-eo
merged commit 835bd0b
into
refactoring/#253-design-system
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌁 Background
📱 Screenshot
👩💻 Contents
로그인 뷰에 있는 textField는 빌더 패턴으로 구현하지 않은 이유는 ??!!?!
빌더 패턴은 복잡한 객체의 생성 과정을 추상화하여 객체를 단계적으로 구성할 수 있는 디자인 패턴입니다. 그러나 로그인 뷰처럼 UI가 사용자 상호작용에 따라 동적으로 변경될 수 있는 경우, 빌더 패턴의 제한이 있을 수 있습니다. 따라서 저는 초기에 로그인 뷰의 textField도 빌더 패턴으로 구현하려 했지만, 객체 생성 과정이 유연하게 대응할 수 있는 패턴을 선택해야 한다고 판단하여, 홈과 검색 뷰의 textField만 빌더 패턴으로 구현했슴돵~,~
✅ Testing
#257 풀땡겨 보세염
📝 Review Note
버튼 클릭 시 발생하는 액션과 텍스트의 비동기 로직은 나중에 다시 구현할 예정입니다.
📣 Related Issue
📬 Reference