-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/qdrant docs reconstruct #776
Open
ThomasRochefortB
wants to merge
4
commits into
Future-House:main
Choose a base branch
from
ThomasRochefortB:feat/Qdrant_docs_reconstruct
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/qdrant docs reconstruct #776
ThomasRochefortB
wants to merge
4
commits into
Future-House:main
from
ThomasRochefortB:feat/Qdrant_docs_reconstruct
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
labels
Dec 21, 2024
Merged
jamesbraza
reviewed
Dec 22, 2024
paperqa/docs.py
Outdated
@@ -848,3 +855,120 @@ async def aquery( # noqa: PLR0912 | |||
session.context = context_str | |||
|
|||
return session | |||
|
|||
async def load_docs_from_qdrant( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we want to keep Docs
as a lightweight and general object. Let's keep DB provider stuff out of Docs
.
Can you perhaps:
- Make this a classmethod or staticmethod on the Qdrant entity
- Make a free function that in that module
Hey @jamesbraza , thank you so much for your time on the review!
|
#778 includes the async changes @jamesbraza |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Docs.load_docs_from_qdrant()
function in order to rebuild aDocs()
object from a QdrantVectorStore.Assuming you have built a QdrantVectorStore using something like:
Then you can rebuild the
Docs
object using: