Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing None failovers in LDP shims #774

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Missing None failovers in LDP shims #774

merged 1 commit into from
Dec 20, 2024

Conversation

jamesbraza
Copy link
Collaborator

#772 created an LDP shim module, but missed that due to __all__ we need None failovers for all entries in __all__.

@jamesbraza jamesbraza added the bug Something isn't working label Dec 20, 2024
@jamesbraza jamesbraza requested a review from a team December 20, 2024 00:12
@jamesbraza jamesbraza self-assigned this Dec 20, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Dec 20, 2024
@jamesbraza jamesbraza merged commit 0dc007b into main Dec 20, 2024
3 of 5 checks passed
@jamesbraza jamesbraza deleted the fixing-no-ldp-users branch December 20, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants