Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping refurb in favor of its ruff port #773

Merged
merged 3 commits into from
Dec 24, 2024
+8 −6
Merged

Dropping refurb in favor of its ruff port #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb86522
Ran 'pre-commit autoupdate'
jamesbraza Dec 19, 2024
36d6b9f
Consoldiated refurb disables for ruff ongoing port
jamesbraza Dec 19, 2024
7144f0a
Dropped refurb from CI
jamesbraza Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
- run: uv python pin ${{ matrix.python-version }}
- uses: hynek/build-and-inspect-python-package@v2
- run: uv sync --python-preference=only-managed
- run: uv run refurb paperqa tests
- run: uv run pylint paperqa
test:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ repos:
- id: mixed-line-ending
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.8.2
rev: v0.8.4
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Expand Down Expand Up @@ -63,7 +63,7 @@ repos:
hooks:
- id: uv-lock
- repo: https://github.com/renovatebot/pre-commit-hooks
rev: 39.58.1
rev: 39.75.1
hooks:
- id: renovate-config-validator
args: [--strict]
Expand Down
9 changes: 6 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,9 @@ testpaths = ["tests"]
[tool.refurb]
enable_all = true
ignore = [
"FURB101", # FURB101, FURB103, FURB141, FURB144, FURB146, FURB147, FURB150, FURB155: no need for pathlib
"FURB103",
"FURB141",
"FURB101", # Rely on ruff FURB101 for this
"FURB103", # Rely on ruff FURB103 for this
"FURB141", # FURB141, FURB144, FURB146, FURB147, FURB150, FURB155: don't care to enforce pathlib
"FURB144",
"FURB146",
"FURB147",
Expand Down Expand Up @@ -379,6 +379,7 @@ extend-select = [
"FURB166",
"FURB171",
"FURB180",
"FURB181",
"FURB188",
"FURB189",
"FURB192",
Expand Down Expand Up @@ -440,6 +441,8 @@ ignore = [
"FBT002",
"FIX", # Don't care to prevent TODO, FIXME, etc.
"FLY002", # Can be less readable
"FURB101", # FURB101, FURB103: don't care to enforce pathlib
"FURB103",
"G004", # f-strings are convenient
"INP001", # Can use namespace packages
"ISC001", # For ruff format compatibility
Expand Down
Loading