Fixed type problems from llmclient #770
Draft
+55
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maykcaldas
force-pushed
the
fix-llmclient-types
branch
from
7b41a4d to
477fb7c
Compare
jamesbraza
reviewed
Dec 18, 2024
jamesbraza
reviewed
Dec 19, 2024
Comment on lines
+57
to
+58
| docname: str | None = None | ||
| dockey: DocKey | None = None |
There was a problem hiding this comment.
Why make these optional and defaulted to None?
I am not against it, but more just wondering why. Can you add a description stating what these should be and what None means
| @@ -683,7 +683,7 @@ def test_sparse_embedding(stub_data_dir: Path, vector_store: type[VectorStore]) | |||
| citation="WikiMedia Foundation, 2023, Accessed now", | |||
| embedding_model=SparseEmbeddingModel(), | |||
| ) | |||
| assert any(docs.texts[0].embedding) | |||
There was a problem hiding this comment.
Can we keep the any assertions around? Why move to list?
If you think the assertion is the same behavior, can you add an assertion failure message, to help make what it's checking for clear?
--- assert any(docs.texts[0].embedding), "We require the embedding to be populated"
+++ assert isinstance(docs.texts[0].embedding, list), "We require the embedding to be populated"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.