Support env states with custom status functions #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
jamesbraza
reviewed
Dec 4, 2024
| @@ -31,13 +32,38 @@ def make_status( | |||
| ) | |||
|
|
|||
|
|
|||
| def default_status(state: "EnvironmentState") -> str: | |||
There was a problem hiding this comment.
You'll need a TYPE_CHECKING block that imports EnvironmentState I think for this to work
There was a problem hiding this comment.
EnvironmentState is in this file, so I think we're good here
There was a problem hiding this comment.
Yep i was wrong here, sorry for false positive comment
jamesbraza
approved these changes
Dec 4, 2024
| @@ -31,13 +32,38 @@ def make_status( | |||
| ) | |||
|
|
|||
|
|
|||
| def default_status(state: "EnvironmentState") -> str: | |||
There was a problem hiding this comment.
Yep i was wrong here, sorry for false positive comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may need custom status messages upon extra tools -- this allows custom status functions to be build into the
EnvironmentState.