Convert citation to formatted_citation usage where necessary #666
+2,908
−2,826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
whitead
approved these changes
Nov 5, 2024
|
good call -- defaulting to an empty string, which I think should be fine. |
jamesbraza
reviewed
Nov 5, 2024
jamesbraza
reviewed
Nov 5, 2024
| ) -> dict[str, Any]: | ||
| if not data.get("journal"): | ||
| doi = data.get("doi", "") or "" | ||
| if "10.48550/" in doi or "ArXiv" in (data.get("other", {}) or {}).get( |
There was a problem hiding this comment.
Can we move this to an external module-level lookup of journal to base DOI?
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
Doc.citationin our queries, which skipped the extra info from our journal quality and citation count metadata.