Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an after model validator ensuring temp=1 for o1 models #649

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

dakoner
Copy link
Contributor

@dakoner dakoner commented Oct 28, 2024

o1-preview and o1-mini in Beta only support temperature=1.

@dakoner dakoner requested a review from whitead October 28, 2024 23:14
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Oct 28, 2024
paperqa/settings.py Outdated Show resolved Hide resolved
paperqa/settings.py Outdated Show resolved Hide resolved
paperqa/settings.py Show resolved Hide resolved
paperqa/settings.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@jamesbraza jamesbraza merged commit fb66ac8 into main Oct 29, 2024
3 of 5 checks passed
@jamesbraza jamesbraza deleted the o1-preview-temperature-validation branch October 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants