Regression protection in embedding_model_factory
#622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
jamesbraza
force-pushed
the
better-testing-embeddings-path
branch
from
3d3b8de to
00df528
Compare
whitead
approved these changes
Oct 22, 2024
jamesbraza
force-pushed
the
better-testing-embeddings-path
branch
from
00df528 to
c8436d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow #604 made
test_paperqa.pymuch faster in CI, and it's not clear why.This PR just adds regression protection to
embedding_model_factoryto confirm it didn't change behaviors