Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing we can use ~ as paper_directory #610

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Testing we can use ~ as paper_directory #610

merged 2 commits into from
Oct 18, 2024

Conversation

jamesbraza
Copy link
Collaborator

Testing we can:

  1. Save Settings with ~ in the paper_directory
  2. Run inferences with Settings containing ~ in the paper_directory

Closes #484

@jamesbraza jamesbraza added the enhancement New feature or request label Oct 18, 2024
@jamesbraza jamesbraza self-assigned this Oct 18, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 18, 2024
whitead
whitead approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@jamesbraza jamesbraza merged commit ef0aec2 into main Oct 18, 2024
3 of 5 checks passed
@jamesbraza jamesbraza deleted the home-dir-paper-dir branch October 18, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: supporting ~ in --paper_directory in CLI
2 participants
@jamesbraza @whitead