Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NumpyVectorStore.clear from not clearing text_hashes #608

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Fixed NumpyVectorStore.clear from not clearing text_hashes #608

merged 3 commits into from
Oct 18, 2024

Conversation

jamesbraza
Copy link
Collaborator

Also, this PR:

  • Adds a regression test for this
  • Loosens and fixes the typing in VectorStore.add_texts_and_embeddings
  • Adds NumpyVectorStore.__eq__ for convenience

@jamesbraza jamesbraza added the bug Something isn't working label Oct 18, 2024
@jamesbraza jamesbraza self-assigned this Oct 18, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 18, 2024
@jamesbraza jamesbraza force-pushed the fixing-np-vector-store branch from 02e337f to a684dc7 Compare October 18, 2024 19:12
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@jamesbraza jamesbraza merged commit 54d28e9 into main Oct 18, 2024
5 checks passed
@jamesbraza jamesbraza deleted the fixing-np-vector-store branch October 18, 2024 19:37
@jamesbraza jamesbraza mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitead whitead whitead approved these changes

@mskarlin mskarlin Awaiting requested review from mskarlin

@nadolskit nadolskit Awaiting requested review from nadolskit

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @whitead