Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent.get_as as an alternative to get_asv #198

Closed
wants to merge 1 commit into from
Closed

Agent.get_as as an alternative to get_asv #198

wants to merge 1 commit into from

Conversation

jamesbraza
Copy link
Collaborator

I wanted to see what this Agent.get_as looks like since we've discussed it before. This PR's motivation is:

  • Right now no agent in LDP estimate value
  • Most unit tests (aka simple scripts) discard value

Pros:

  • Simplicity/one less piece of information to comprehend for basic Agent implementations

Cons:

  • Introduces room for ambiguity in runner code
  • Introduces possible necessity for duplication across get_as and get_asv
  • get_as is confusing because "as" is actually an English word, whereas "asv" is not
    • If you read as "get as" instead of "get action state" at first glance it's confusing

@jamesbraza jamesbraza added the enhancement New feature or request label Dec 30, 2024
@jamesbraza jamesbraza self-assigned this Dec 30, 2024
@jamesbraza
Copy link
Collaborator Author

Open to others opinions here, but reading through I feel the cons of Agent.get_as outweigh the pros of Agent.get_asv, so going to close this PR

@jamesbraza jamesbraza closed this Dec 30, 2024
@jamesbraza jamesbraza deleted the get-as branch December 30, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant