Catch closing exceptions #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidnarayanan
requested review from
whitead,
jamesbraza,
Ryan-Rhys and
albertbou92
jamesbraza
approved these changes
Nov 27, 2024
|
|
||
| If catch_env_failures is set, will not raise exceptions. | ||
| """ | ||
| with suppress(EnvError), reraise_exc_as(EnvError, enabled=catch_env_failures): |
There was a problem hiding this comment.
Will this log the closing's Exception somewhere? Would be good to log it at least
There was a problem hiding this comment.
Yep, reraise_exc_as has logging builtin. This is the same logic that we use to catch reset/step exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending
catch_env_failuresto coverenv.close(). I just lost a ~24h training because a remote env failed to close, so I want to protect against that.