Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit hook for linting and formatting #1629

Closed
wants to merge 27 commits into from

Conversation

Adi8712
Copy link

@Adi8712 Adi8712 commented Oct 11, 2024

Proposed changes

Using ruff for linting and formatting

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe): maintenance

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Other information

pre-commit install takes care of everything

@Adi8712
Copy link
Author

Adi8712 commented Oct 16, 2024

@ramG-reddy PTAL

ramG-reddy and others added 24 commits October 20, 2024 11:37
…ied the Student_grades table in online_cms module
… can be given to faculty by dean and acadadmin can only read and verify the data, revoked him of write access
* Changed Template Files: Co authored by Abhyuday Singh and Arghadeep Bosu

* Configured Backend: Added new feature in Examination module and modified the Student_grades table in online_cms module

* added migration file for the attributes changed in online_cms module

* added dean actor and gave verification powers only to dean and not to acad admin

* Examination Module completed: Dean academic added, resubmission power can be given to faculty by dean and acadadmin can only read and verify the data, revoked him of write access

---------

Co-authored-by: Arghadeep Bosu <[email protected]>
feat(AC2): Added support for elective preregistration and corrected preregistration process
@Adi8712 Adi8712 changed the base branch from latest_staging to dashboard_client October 24, 2024 09:17
* Implemented suggested changes in AC-2
- Important Validations
- Random elective allocation algo implementation in utils
- New page for starting allocation process

* migrations for previous changes

* field changes in random allocation algo and start allocation form

* Implemented the preregistration algorithm

* Added allocated course viewing page
- fixed bugs in algo

* Restricted scope of the algo to only Open electives

---------

Co-authored-by: ChallaBharadwajReddy <[email protected]>
@Adi8712 Adi8712 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants