Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revert with log function to std lib #6717

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Add revert with log function to std lib #6717

merged 10 commits into from
Nov 14, 2024

Conversation

SwayStar123
Copy link
Member

@SwayStar123 SwayStar123 commented Nov 12, 2024 •
edited by IGI-111
Loading

Description

Adds a revert_with_log function that reverts unconditionally with a message

Closes #6629

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Nov 12, 2024
@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Nov 12, 2024
@SwayStar123 SwayStar123 marked this pull request as ready for review November 12, 2024 15:53
@SwayStar123 SwayStar123 requested review from a team as code owners November 12, 2024 15:53
@IGI-111 IGI-111 changed the title Add revert with message/panic function to std lib Add revert with log function to std lib Nov 13, 2024
@IGI-111 IGI-111 requested a review from a team November 13, 2024 12:35
@SwayStar123 SwayStar123 reopened this Nov 14, 2024
@SwayStar123 SwayStar123 merged commit f7fa086 into master Nov 14, 2024
64 of 77 checks passed
@SwayStar123 SwayStar123 deleted the swaystar-revert_with_message branch November 14, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@IGI-111 IGI-111 IGI-111 approved these changes

@tritao tritao tritao approved these changes

@bitzoic bitzoic Awaiting requested review from bitzoic

@sdankel sdankel Awaiting requested review from sdankel

Assignees

@SwayStar123 SwayStar123

Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert with message
5 participants
@SwayStar123 @tritao @IGI-111 @sdankel @K1-R1