Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurables section offset in the preamble #6709

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    b75e6fd View commit details
    Browse the repository at this point in the history
  2. Add configurables section offset in the preamble (#6522)

    The preamble now contains 8 bytes of offset to the configurables
    section. If there is no configurable const in the data-section, then the
    value of this integer will be equal to the size of the binary itself.
    
    This also means that we now sort the data-section to have all the
    non-configurables first, and then the configurables.
    
    The preamble final asm looks like this (the offset to configurables is
    0'd out here in the example):
    ```
    ;; ASM: Final program
    ;; Program kind: Script
    .program:
    move $$tmp $pc
    jmpf $zero i10
    DATA_SECTION_OFFSET[0..32]
    DATA_SECTION_OFFSET[32..64]
    CONFIGURABLES_OFFSET[0..32]
    CONFIGURABLES_OFFSET[32..64]
    lw   $$ds $$tmp i1
    add  $$ds $$ds $$tmp
    ```
    The preamble bytecode looks like this:
    
    ```
    0x00000000 MOVE R60 $pc                                    ;; [26, 240, 48, 0]
    0x00000004 JMPF $zero 0xa                                  ;; [116, 0, 0, 10]
    0x00000008                                                 ;; [0, 0, 0, 0, 0, 0, 2, 40]
    0x00000010                                                 ;; [0, 0, 0, 0, 0, 0, 0, 0]
    0x00000030 LW R63 R60 0x1                                  ;; [93, 255, 192, 1]
    0x00000034 ADD R63 R63 R60                                 ;; [16, 255, 255, 0]
    ...
    ```
    
    ---------
    
    Co-authored-by: Sophie Dankel <[email protected]>
    Co-authored-by: IGI-111 <[email protected]>
    3 people committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0e875cf View commit details
    Browse the repository at this point in the history
  3. update deployment tests

    vaivaswatha committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    938974e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4dee09c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    595a6bc View commit details
    Browse the repository at this point in the history
  6. Add configurables section offset in the preamble (#6522)

    The preamble now contains 8 bytes of offset to the configurables
    section. If there is no configurable const in the data-section, then the
    value of this integer will be equal to the size of the binary itself.
    
    This also means that we now sort the data-section to have all the
    non-configurables first, and then the configurables.
    
    The preamble final asm looks like this (the offset to configurables is
    0'd out here in the example):
    ```
    ;; ASM: Final program
    ;; Program kind: Script
    .program:
    move $$tmp $pc
    jmpf $zero i10
    DATA_SECTION_OFFSET[0..32]
    DATA_SECTION_OFFSET[32..64]
    CONFIGURABLES_OFFSET[0..32]
    CONFIGURABLES_OFFSET[32..64]
    lw   $$ds $$tmp i1
    add  $$ds $$ds $$tmp
    ```
    The preamble bytecode looks like this:
    
    ```
    0x00000000 MOVE R60 $pc                                    ;; [26, 240, 48, 0]
    0x00000004 JMPF $zero 0xa                                  ;; [116, 0, 0, 10]
    0x00000008                                                 ;; [0, 0, 0, 0, 0, 0, 2, 40]
    0x00000010                                                 ;; [0, 0, 0, 0, 0, 0, 0, 0]
    0x00000030 LW R63 R60 0x1                                  ;; [93, 255, 192, 1]
    0x00000034 ADD R63 R63 R60                                 ;; [16, 255, 255, 0]
    ...
    ```
    
    ---------
    
    Co-authored-by: Sophie Dankel <[email protected]>
    Co-authored-by: IGI-111 <[email protected]>
    3 people committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    60cad51 View commit details
    Browse the repository at this point in the history
  7. update tests

    vaivaswatha committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    c6756b6 View commit details
    Browse the repository at this point in the history
  8. fix warning

    vaivaswatha committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    95a8f18 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Configuration menu
    Copy the full SHA
    69f0224 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Configuration menu
    Copy the full SHA
    b8d3ff5 View commit details
    Browse the repository at this point in the history
  2. update tests

    vaivaswatha committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3852613 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    7711be8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41abe98 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f37de7 View commit details
    Browse the repository at this point in the history