-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurables section offset in the preamble #6709
Open
vaivaswatha
wants to merge
14
commits into
master
Choose a base branch
from
vaivaswatha/configurables_access
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+463
−189
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b75e6fd - Browse repository at this point
Copy the full SHA b75e6fdView commit details -
Add configurables section offset in the preamble (#6522)
The preamble now contains 8 bytes of offset to the configurables section. If there is no configurable const in the data-section, then the value of this integer will be equal to the size of the binary itself. This also means that we now sort the data-section to have all the non-configurables first, and then the configurables. The preamble final asm looks like this (the offset to configurables is 0'd out here in the example): ``` ;; ASM: Final program ;; Program kind: Script .program: move $$tmp $pc jmpf $zero i10 DATA_SECTION_OFFSET[0..32] DATA_SECTION_OFFSET[32..64] CONFIGURABLES_OFFSET[0..32] CONFIGURABLES_OFFSET[32..64] lw $$ds $$tmp i1 add $$ds $$ds $$tmp ``` The preamble bytecode looks like this: ``` 0x00000000 MOVE R60 $pc ;; [26, 240, 48, 0] 0x00000004 JMPF $zero 0xa ;; [116, 0, 0, 10] 0x00000008 ;; [0, 0, 0, 0, 0, 0, 2, 40] 0x00000010 ;; [0, 0, 0, 0, 0, 0, 0, 0] 0x00000030 LW R63 R60 0x1 ;; [93, 255, 192, 1] 0x00000034 ADD R63 R63 R60 ;; [16, 255, 255, 0] ... ``` --------- Co-authored-by: Sophie Dankel <[email protected]> Co-authored-by: IGI-111 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0e875cf - Browse repository at this point
Copy the full SHA 0e875cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 938974e - Browse repository at this point
Copy the full SHA 938974eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dee09c - Browse repository at this point
Copy the full SHA 4dee09cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 595a6bc - Browse repository at this point
Copy the full SHA 595a6bcView commit details -
Add configurables section offset in the preamble (#6522)
The preamble now contains 8 bytes of offset to the configurables section. If there is no configurable const in the data-section, then the value of this integer will be equal to the size of the binary itself. This also means that we now sort the data-section to have all the non-configurables first, and then the configurables. The preamble final asm looks like this (the offset to configurables is 0'd out here in the example): ``` ;; ASM: Final program ;; Program kind: Script .program: move $$tmp $pc jmpf $zero i10 DATA_SECTION_OFFSET[0..32] DATA_SECTION_OFFSET[32..64] CONFIGURABLES_OFFSET[0..32] CONFIGURABLES_OFFSET[32..64] lw $$ds $$tmp i1 add $$ds $$ds $$tmp ``` The preamble bytecode looks like this: ``` 0x00000000 MOVE R60 $pc ;; [26, 240, 48, 0] 0x00000004 JMPF $zero 0xa ;; [116, 0, 0, 10] 0x00000008 ;; [0, 0, 0, 0, 0, 0, 2, 40] 0x00000010 ;; [0, 0, 0, 0, 0, 0, 0, 0] 0x00000030 LW R63 R60 0x1 ;; [93, 255, 192, 1] 0x00000034 ADD R63 R63 R60 ;; [16, 255, 255, 0] ... ``` --------- Co-authored-by: Sophie Dankel <[email protected]> Co-authored-by: IGI-111 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 60cad51 - Browse repository at this point
Copy the full SHA 60cad51View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6756b6 - Browse repository at this point
Copy the full SHA c6756b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95a8f18 - Browse repository at this point
Copy the full SHA 95a8f18View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 69f0224 - Browse repository at this point
Copy the full SHA 69f0224View commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b8d3ff5 - Browse repository at this point
Copy the full SHA b8d3ff5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3852613 - Browse repository at this point
Copy the full SHA 3852613View commit details
Commits on Nov 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7711be8 - Browse repository at this point
Copy the full SHA 7711be8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41abe98 - Browse repository at this point
Copy the full SHA 41abe98View commit details -
Merge branch 'master' of github.com:FuelLabs/sway into vaivaswatha/co…
…nfigurables_access
Configuration menu - View commit details
-
Copy full SHA for 4f37de7 - Browse repository at this point
Copy the full SHA 4f37de7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.