Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes double call of get_items_for_type. #6626

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions sway-core/src/semantic_analysis/type_check_context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1183,20 +1183,22 @@ impl<'a> TypeCheckContext<'a> {
type_engine.insert(self.engines, TypeInfo::ErrorRecovery(err), None)
});

// grab the module where the type itself is declared
let type_module = self.namespace().lookup_submodule_from_absolute_path(
handler,
self.engines(),
item_prefix,
)?;
let mut items = local_items;
if item_prefix != self.namespace().mod_path {
// grab the module where the type itself is declared
let type_module = self.namespace().lookup_submodule_from_absolute_path(
handler,
self.engines(),
item_prefix,
)?;

// grab the items from where the type is declared
let mut type_items = type_module
.current_items()
.get_items_for_type(self.engines, type_id);
// grab the items from where the type is declared
let mut type_items = type_module
.current_items()
.get_items_for_type(self.engines, type_id);

let mut items = local_items;
items.append(&mut type_items);
items.append(&mut type_items);
}

let mut matching_item_decl_refs: Vec<ty::TyTraitItem> = vec![];

Expand Down
Loading