SRC-14: Owned Proxy #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependent on FuelLabs/sway-libs#259 |
|
Are you able to pull CI and repo setup functionality to a separate PR to keep things clean? |
#4 contains the CI on it's own, but the checks fail as the files don't exist |
Merged
bitzoic
approved these changes
Jul 14, 2024
DefiCake
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
lgtm
not in the scope of this PR, but in the sway libs:
CannotReinitializedshould beCannotReinitialize?- Accidentally default-ing the contained address in State::Initialized (ie
State::Initialized(Default::default())) for the owner seems more probable in rust than in other languages. I am not one to complain about these things but it has been raised here and there in audits and in the hackathon. For the minor gas cost and the major time savings in telling people to f-off.. I 'd say it is worth it, but ultimately up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an SRC-14 compliant owned proxy contract that uses the new Upgradability lib from sway-libs. As well as basic repo setup
Closes #2