Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate reentrancy to new directory structure #83

Merged
merged 11 commits into from
Feb 1, 2023
Merged

migrate reentrancy to new directory structure #83

merged 11 commits into from
Feb 1, 2023

Conversation

jtriley-eth
Copy link
Contributor

Reentrancy Library Migration

Changes

The following changes have been made:

  • Reentrancy library has been migrated from the std library to sway-libs
  • Reentrancy tests have been migrated
  • A new directory, test_artifacts has been introduced for multi-contract tests
  • The build script (.github/scripts/build.sh) has been modified to build test_artifacts

Notes

  • It may be worth reviewing the rest of the ci pipeline to ensure the new directory is handled properly

Related Issues

Part 1 of Issue 3217 in Fuellabs/sway

@jtriley-eth jtriley-eth marked this pull request as ready for review January 23, 2023 20:29
@mohammadfawaz mohammadfawaz mentioned this pull request Jan 26, 2023
Closed
@nfurfaro
Copy link
Contributor

@jtriley-eth Do you want to perhaps improve the docs for reentrancy_guard while you're touching these files?
I opened this PR to do that, but it makes more sense to make the changes here.

bitzoic
bitzoic reviewed Jan 31, 2023
View reviewed changes
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the library to the source README so users are able to easily find it?

Besides a few minor comments LGTM! 🚀

libs/reentrancy/README.md Show resolved Hide resolved
tests/src/reentrancy/mod.rs Show resolved Hide resolved
libs/reentrancy/README.md Show resolved Hide resolved
libs/reentrancy/src/lib.sw Show resolved Hide resolved
nfurfaro
nfurfaro reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise looks good!

libs/reentrancy/SPECIFICATION.md Outdated Show resolved Hide resolved
bitzoic
bitzoic approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@bitzoic bitzoic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitzoic bitzoic added New Feature New addition that does not currently exist Lib: Security Label used to filter for the library issue labels Feb 1, 2023
@bitzoic bitzoic merged commit 4ca20a0 into master Feb 1, 2023
@bitzoic bitzoic deleted the jtriley-eth/migrate-reentrancy branch February 1, 2023 17:19
@jtriley-eth jtriley-eth mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfurfaro nfurfaro nfurfaro left review comments

@bitzoic bitzoic bitzoic approved these changes

@simonr0204 simonr0204 Awaiting requested review from simonr0204

Assignees

@jtriley-eth jtriley-eth

Labels
Lib: Security Label used to filter for the library issue New Feature New addition that does not currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtriley-eth @nfurfaro @bitzoic