Revert remove _with_configurables functions from Bytecode Library and use Option instead #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwayStar123
approved these changes
Aug 30, 2024
K1-R1
approved these changes
Aug 30, 2024
Merged
bitzoic
added a commit
that referenced
this pull request
Sep 2, 2024
## Type of change <!--Delete points that do not apply--> - Release ## [Version 0.24.0] ### Added v0.24.0 - [#293](#293) Adds the `BytecodeRoot` and `ContractConfigurables` types to the Bytecode Library. - [#286](#286) Adds the `_metadata()` function to the Asset Library. ### Changed v0.24.0 - [#286](#286) Updates the repository to Sway-Standards v0.6.0 and implements the new SRC-20 and SRC-7 logging specifications. - [#286](#286) `_set_metadata()`, `_set_name()` and `_set_symbol()` now revert if the metadata is an empty string. - [#286](#286) `_set_metadata()` now reverts if the metadata is empty bytes. - [#286](#286) `_mint()` and `_burn()` now revert if the `amount` argument is zero. - [#289](#289) Bumps Sway-Libs to forc `v0.63.3`, fuel-core `v0.34.0`, and fuels `v0.66.2`. - [#290](#290) Update the Upgradeability library to use a specific storage slot for owner functionality. - [#291](#291) Prepares for the `v0.24.0` release. ### Breaking v0.24.0 - [#290](#290) The `_proxy_owner()`, `only_proxy_owner()` and `_set_proxy_owner()` functions no longer take `storage.proxy_owner` as a parameter. Instead they directly read and write to the storage slot `0xbb79927b15d9259ea316f2ecb2297d6cc8851888a98278c0a2e03e1a091ea754` which is `sha256("storage_SRC14_1")`. Before: ```sway fn foo() { let stored_proxy_owner = _proxy_owner(storage.proxy_owner); only_proxy_owner(storage.proxy_owner); _set_proxy_owner(new_proxy_owner, storage.proxy_owner); } ``` After: ```sway fn foo() { let stored_proxy_owner = _proxy_owner(); only_proxy_owner(); _set_proxy_owner(new_proxy_owner); } ``` --------- Signed-off-by: withbest <[email protected]> Co-authored-by: K1-R1 <[email protected]> Co-authored-by: SwayStar123 <[email protected]> Co-authored-by: withbest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Changes
The following changes have been made:
_with_configurablesfunctions from Bytecode Library and useOptioninstead #285BytecodeRootandContractconfigurablestypesChecklist
Breaking*orNew Featurelabels where relevant.