Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to forc v0.60.0 #250

Merged
merged 9 commits into from
May 31, 2024
Merged

Update to forc v0.60.0 #250

merged 9 commits into from
May 31, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented May 23, 2024

Type of change

  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

  • Updates the repository to use forc v0.60.0
  • Makes fields in signed integers and fixed point numbers private
  • Adds Self::zero(), self::is_zero(), and self::underlying() to signed integers and fixed point numbers

Breaking Changes

Public struct fields are now PRIVATE in the fixed_point and signed_integers libraries. If the fields are needed, they can be fetched with a corresponding my_type.underlying() function. For example, I8's underlying u8 may be fetched with:

let my_i8: I8 = I8::zero();
let underlying: u8 = my_i8.underlying();

For types that have a non_negative field, the same applies:

let my_ifp64: IFP64 = IFP64::zero();
let non_negative: bool = my_ifp64.non_negative();

@bitzoic bitzoic self-assigned this May 23, 2024
@bitzoic bitzoic requested a review from a team as a code owner May 23, 2024 07:18
@bitzoic bitzoic added Repo Misc General repository upkeep Breaking This will break user's code labels May 23, 2024
@bitzoic
Copy link
Member Author

bitzoic commented May 23, 2024

Dependent on FuelLabs/sway-standards#96

K1-R1
K1-R1 previously approved these changes May 29, 2024
@K1-R1 K1-R1 requested a review from a team May 29, 2024 17:36
@bitzoic bitzoic merged commit cc09dae into master May 31, 2024
10 checks passed
@bitzoic bitzoic deleted the bitzoic-bum-v60 branch May 31, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking This will break user's code Repo Misc General repository upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants