Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to forc 0.44.1 #185

Merged
merged 8 commits into from
Aug 22, 2023
Merged

Bump to forc 0.44.1 #185

merged 8 commits into from
Aug 22, 2023

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Aug 21, 2023 •
edited
Loading

Type of change

  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

  • Bumped libraries to forc v0.44.1
  • Bumped libraries to fuel-core v0.20.3
  • Bumped libraries to rust v0.71.1
  • Bump libraries to fuels-rs v0.46.0
  • Archived the NFT library due to the introduction of the token standard

Notes

@bitzoic bitzoic added Improvement Enhancing a feature that already exists Repo Misc General repository upkeep labels Aug 21, 2023
@bitzoic bitzoic self-assigned this Aug 21, 2023
@bitzoic bitzoic requested a review from a team as a code owner August 21, 2023 14:51
Braqzen
Braqzen reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Braqzen Braqzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't archive by removing it from CI. I'd keep it there and keep bumping but note that the standard is out of date and should not be followed.

This at least shows the up to date code

libs/archive/nft/README.md Outdated Show resolved Hide resolved
tests/src/fixed_point/ufp32_test/src/main.sw Outdated Show resolved Hide resolved
@bitzoic
Copy link
Member Author

bitzoic commented Aug 21, 2023

I wouldn't archive by removing it from CI. I'd keep it there and keep bumping but note that the standard is out of date and should not be followed.

This at least shows the up to date code

This is very far off from what we would like to promote as good Sway code. I've opted to leave it only so that existing projects are able to reference it. As soon as #187 is closed it will be removed entirely.

@Braqzen
Copy link
Contributor

Braqzen commented Aug 21, 2023

I wouldn't archive by removing it from CI. I'd keep it there and keep bumping but note that the standard is out of date and should not be followed.
This at least shows the up to date code

This is very far off from what we would like to promote as good Sway code. I've opted to leave it only so that existing projects are able to reference it. As soon as #187 is closed it will be removed entirely.

If we are not maintaining it and it's bad code why not just remove it now?

@bitzoic bitzoic requested a review from a team August 21, 2023 19:19
@bitzoic bitzoic merged commit 3c6c933 into master Aug 22, 2023
3 checks passed
@bitzoic bitzoic deleted the bump_forc_0.44.1 branch August 22, 2023 13:11
@bitzoic bitzoic mentioned this pull request Aug 22, 2023
Closed
This was referenced Aug 22, 2023
Merged
Merged
kayagokalp added a commit to FuelLabs/sway that referenced this pull request Aug 22, 2023
@kayagokalp
docs: fix nft example links in docs (#4998)
73b02df 
## Description

`nft` module in `sway-libs` moved and some of our links are dead after
FuelLabs/sway-libs#185. This PR fixes links so
that they pointing to the new position. This blocks our CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Braqzen Braqzen Braqzen left review comments

@K1-R1 K1-R1 K1-R1 approved these changes

Assignees

@bitzoic bitzoic

Labels
Improvement Enhancing a feature that already exists Repo Misc General repository upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitzoic @Braqzen @K1-R1