Fix CMD Key Issue with useKeyboardControls in Player Component #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the keyboard controls within the Player component, specifically addressing an issue where the combination of CMD (on macOS) or Control (on other platforms) keys with movement keys (e.g., arrow keys) did not function as expected. The update ensures a smoother and more intuitive control scheme for users, facilitating better gameplay experience by allowing simultaneous use of command keys with movement controls.
|
|
AlexMubarakshin
changed the title
Reset the state of keyboard controls when the meta key (CMD on macOS) is pressed.
AlexMubarakshin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exploring the
useKeyboardControlshook fromreact-three/dreifor Player component, I discovered an issue exclusive to macOS users. The hook fails to ignore the CMD key, leading to a scenario where the character begins to move non-stop in one direction after a player uses a combination of the CMD key and a movement key (e.g., CMD+S for fullscreen). This behavior disrupts the gameplay experience and conflicts with common macOS shortcuts, causing unexpected and confusing behavior for the players.Steps to Reproduce
Solution and Implementation
To address this issue, I added a feature to the custom hook that intercepts and processes keyboard events, explicitly ignoring any inputs involving the CMD key. Additionally, the hook resets the controls state whenever the CMD key is pressed, immediately halting any ongoing movement commands. This ensures the character does not move indefinitely, allowing macOS users to use system shortcuts without triggering continuous movement in the game.