-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix component install when fail to be installed at the first time #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Halimao
changed the title
fix: fix component install when fail to install at the first time
fix: fix component install when fail to be installed at the first time
Nov 21, 2023
sdankel
reviewed
Dec 1, 2023
sdankel
previously approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally and it seems to be working well. Thanks!
@sdankel Hi, update the code style to let ci cargo-fmt-check happy~ |
sdankel
approved these changes
Dec 4, 2023
@sdankel Hi sir, can we get this merged, as this is a bug fix😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fuelup toolchain install latest
won't work properly if fail to be installed at the first time.When we run
fuelup toolchain install latest
again, it will show all components are installed. Actually, the components which were failed to be installed at first time are still missing.The reason is downloader will create file before downloading process start and won't delete file after downloading process is fail. Also,
add_component
checks the component file~/.fuelup/store/{component-version}-xxx.tar.gz
is exist, and then won't install the component anymore.logs about
fuelup toolchain install latest
been executed at first time:logs about
fuelup toolchain install latest
been executed again.