Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: finalise docs-snippets #3369

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Oct 30, 2024

Summary

  • Finalized the migration of the docs-snippets to docs
  • Migrate some final docs snippets that we missed:

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the docs Requests pertinent to documentation label Oct 30, 2024
@petertonysmith94 petertonysmith94 self-assigned this Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:47am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-docs-api ⬜️ Ignored (Inspect) Nov 14, 2024 4:47am

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #3369 will not alter performance

Comparing ps/docs/finalise-docs-snippets (8ba0f4a) with master (5dee7ff)

Summary

✅ 18 untouched benchmarks

@petertonysmith94
Copy link
Contributor Author

We need to make some changes to the docs-hub GitHub workflow as it's currently failing in CI.

I'm opening this for review as it should be isolated to the github-actions repository.

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.93%(+12.58%) 70.37%(+0.74%) 75.36%(+2.04%) 77.04%(+12.25%)
Changed Files:

Coverage values did not change👌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old docs-snippets directory
3 participants