Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: only run release workflow if tests pass #1769

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

chore: only run release workflow if tests pass #1769

wants to merge 13 commits into from

Conversation

Dhaiwat10
Copy link
Member

Closes #1718

@Dhaiwat10 Dhaiwat10 added the chore Issue is a chore label Feb 19, 2024
@Dhaiwat10 Dhaiwat10 self-assigned this Feb 19, 2024
@Dhaiwat10 Dhaiwat10 marked this pull request as ready for review February 19, 2024 06:51
arboleya
arboleya approved these changes Feb 19, 2024
View reviewed changes
.github/workflows/release.yaml Show resolved Hide resolved
@Dhaiwat10
Copy link
Member Author

@arboleya feel free to merge this one whenever you think it's a good time to do so

arboleya
arboleya reviewed Feb 21, 2024
View reviewed changes
.github/workflows/release.yaml

concurrency: ${{ github.workflow }}-${{ github.ref }}

jobs:
release:
name: "Release"
if: ${{ github.event.workflow_run.conclusion == 'success'}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

[note to self]: Ideally we should not merge this before addressing:

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.48%(-0.02%) 70.29%(-0.06%) 78.04%(+0.06%) 79.57%(-0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/predicate/predicate.ts 31.37%
(+0%)		 25%
(-10.71%)		 27.27%
(+7.27%)		 31.37%
(+0%)
🔴 packages/create-fuels/src/cli.ts 85.89%
(-0.18%)		 67.56%
(+0%)		 83.33%
(+0%)		 86.41%
(-0.17%)
✅ packages/fuels/src/cli/commands/deploy/createWallet.ts 100%
(+8.34%)		 100%
(+16.67%)		 100%
(+0%)		 100%
(+8.34%)

@petertonysmith94
Copy link
Contributor

Warning

[note to self]: Ideally we should not merge this before addressing:

Converted back to a draft until it's ready.

@petertonysmith94 petertonysmith94 marked this pull request as draft May 10, 2024 08:35
@arboleya arboleya added this to the 0.x mainnet milestone Jun 12, 2024
@arboleya arboleya removed this from the 0.x mainnet milestone Jul 19, 2024
@petertonysmith94
Copy link
Contributor

Once #3014 is resolved, I believe we should look at merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@maschad maschad Awaiting requested review from maschad maschad will be requested when the pull request is marked ready for review maschad is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweak release workflow to abort if tests fail
6 participants
@Dhaiwat10 @petertonysmith94 @arboleya @danielbate @nedsalk @Torres-ssf