Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: finalise docs-snippets #3369

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

docs: finalise docs-snippets #3369

wants to merge 23 commits into from
+603 −7,892

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Oct 30, 2024 •
edited
Loading

Summary

  • Finalized the migration of the docs-snippets to docs
  • Migrate some final docs snippets that we missed:

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the docs Requests pertinent to documentation label Oct 30, 2024
@petertonysmith94 petertonysmith94 self-assigned this Oct 30, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ❌ Failed (Inspect) Nov 15, 2024 5:46am
ts-docs ❌ Failed (Inspect) Nov 15, 2024 5:46am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-docs-api ⬜️ Ignored (Inspect) Nov 15, 2024 5:46am

@petertonysmith94 petertonysmith94 mentioned this pull request Nov 8, 2024
Merged
4 tasks
@petertonysmith94 petertonysmith94 mentioned this pull request Nov 13, 2024
Merged
4 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3369 will not alter performance

Comparing ps/docs/finalise-docs-snippets (8ba0f4a) with master (5dee7ff)

Summary

✅ 18 untouched benchmarks

@petertonysmith94
Copy link
Contributor Author

We need to make some changes to the docs-hub GitHub workflow as it's currently failing in CI.

I'm opening this for review as it should be isolated to the github-actions repository.

@petertonysmith94 petertonysmith94 mentioned this pull request Nov 14, 2024
Closed
4 tasks
@petertonysmith94 petertonysmith94 marked this pull request as ready for review November 14, 2024 03:23
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.93%(+12.58%) 70.37%(+0.74%) 75.36%(+2.04%) 77.04%(+12.25%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@petertonysmith94 petertonysmith94

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old docs-snippets directory
3 participants
@petertonysmith94 @Dhaiwat10 @Torres-ssf