Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposals to multi get PR #2419

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Proposals to multi get PR #2419

merged 1 commit into from
Oct 31, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Oct 31, 2024

Proposals to the #2396

@xgreenx xgreenx requested a review from netrome October 31, 2024 10:42
@xgreenx xgreenx self-assigned this Oct 31, 2024
netrome
netrome approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal. It's a great improvement to not have to box the iterators at all levels.

crates/fuel-core/src/state/historical_rocksdb.rs
@@ -395,6 +398,21 @@ where
self.db.get(key, Column::OriginalColumn(column))
}

fn get_batch<'a>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this implementation as well.

@netrome netrome merged commit 2c2d222 into 2344-add-support-for-multi-get-operation-in-the-database Oct 31, 2024
18 of 19 checks passed
@netrome netrome deleted the feature/proposals-to-multi-get-pr branch October 31, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netrome netrome netrome approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees

@xgreenx xgreenx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgreenx @netrome