Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test node herself in reserved nodes. #2390

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Add test node herself in reserved nodes. #2390

merged 13 commits into from
Nov 14, 2024

Conversation

AurelienFT
Copy link
Contributor

Linked Issues/PRs

Closes #1188

Description

Add a test to verfiy that we don't connect to ourself if we are in the reserved nodes.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Oct 24, 2024
@AurelienFT
Copy link
Contributor Author

Seems like the test is timing out on CI. Changing this to draft

@AurelienFT AurelienFT marked this pull request as draft October 28, 2024 12:05
@AurelienFT AurelienFT self-assigned this Oct 28, 2024
@AurelienFT AurelienFT marked this pull request as ready for review October 29, 2024 10:21
@xgreenx xgreenx marked this pull request as draft October 30, 2024 15:46
@AurelienFT AurelienFT marked this pull request as ready for review October 30, 2024 16:13
@AurelienFT AurelienFT requested review from xgreenx and a team October 30, 2024 16:13
xgreenx
xgreenx reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task is more about the same peer_id, not the port or address.

@AurelienFT
Copy link
Contributor Author

The task is more about the same peer_id, not the port or address.

You mean two different peer with two different port but the same peer id ? This simplify a lot ahah

@AurelienFT AurelienFT marked this pull request as draft October 30, 2024 16:24
@xgreenx
Copy link
Collaborator

xgreenx commented Oct 30, 2024

You mean two different peer with two different port but the same peer id ? This simplify a lot ahah

Yeah=D

@AurelienFT AurelienFT marked this pull request as ready for review October 31, 2024 00:20
@AurelienFT AurelienFT requested review from xgreenx and a team October 31, 2024 00:20
@AurelienFT AurelienFT requested a review from a team November 14, 2024 10:52
rafal-ch
rafal-ch approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@rafal-ch rafal-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AurelienFT AurelienFT enabled auto-merge (squash) November 14, 2024 17:13
@AurelienFT AurelienFT merged commit d013a99 into master Nov 14, 2024
34 checks passed
@AurelienFT AurelienFT deleted the add_test_p2p_multiaddr branch November 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafal-ch rafal-ch rafal-ch approved these changes

@xgreenx xgreenx xgreenx approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees

@AurelienFT AurelienFT

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
3 participants
@AurelienFT @xgreenx @rafal-ch