Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Benchmark multi-get implementation #2422

Open
netrome opened this issue Nov 1, 2024 · 1 comment · May be fixed by #2433
Open

chore: Benchmark multi-get implementation #2422

netrome opened this issue Nov 1, 2024 · 1 comment · May be fixed by #2433
Assignees
@netrome

Comments

@netrome
Copy link
Contributor

netrome commented Nov 1, 2024

Context

This PR #2396 introduces multi-get for a few graphql fields. This introduces some extra complexity in the code but is presumed to increase the performance of these queries. To be able to measure the impact of this change, we need to introduce a new benchmark.

Definition of Done

We have a benchmark to measure the performance impact of the multi-get implementation in #2396.
@netrome netrome self-assigned this Nov 1, 2024
@netrome
Copy link
Contributor Author

netrome commented Nov 9, 2024

Aiming at implementing the workload as a stand-alone binary, and use hyperfine for to benchmark this binary.

@netrome netrome linked a pull request Nov 13, 2024 that will close this issue
Draft
@netrome netrome linked a pull request Nov 13, 2024 that will close this issue
feat: simple bench target for measuring end to end query times #2433
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netrome netrome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: simple bench target for measuring end to end query times FuelLabs/fuel-core
1 participant
@netrome