Treat warnings like an error (#1258)

The fix for [failed
publishing](https://github.com/FuelLabs/fuel-core/actions/runs/5581278182)

.github/workflows/ci.yml

@@ -86,6 +86,8 @@ jobs:
       - prevent-openssl
       - rustfmt
     runs-on: buildjet-4vcpu-ubuntu-2204
+    env:
+      RUSTFLAGS: -D warnings
     strategy:
       matrix:
         include:

bin/fuel-core-client/src/main.rs

@@ -1,4 +1,6 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
+
 use clap::Parser;
 use fuel_core_client::client::FuelClient;
 use fuel_core_types::fuel_tx::{

bin/fuel-core/src/main.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 // Use Jemalloc for main binary
 #[global_allocator]

crates/chain-config/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 pub mod config;
 mod genesis;

crates/client/src/client.rs

@@ -857,7 +857,7 @@ impl FuelClient {
         commit_block_id: Option<&BlockId>,
         commit_block_height: Option<BlockHeight>,
     ) -> io::Result<Option<types::MessageProof>> {
-        let transaction_id: schema::TransactionId = (*transaction_id).into();
+        let transaction_id: TransactionId = (*transaction_id).into();
         let message_id: schema::MessageId = (*message_id).into();
         let commit_block_id: Option<schema::BlockId> =
             commit_block_id.map(|commit_block_id| (*commit_block_id).into());

crates/client/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 pub mod client;
 #[cfg(feature = "dap")]
 pub mod schema;

crates/database/src/lib.rs

@@ -6,6 +6,7 @@
 
 #![deny(missing_docs)]
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 use fuel_core_storage::Error as StorageError;
 use fuel_core_types::services::executor::Error as ExecutorError;

crates/fuel-core/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 #[doc(no_inline)]
 pub use fuel_core_chain_config as chain_config;

crates/fuel-core/src/service/adapters/block_importer.rs

@@ -84,14 +84,14 @@ impl RelayerPort for MaybeRelayerAdapter {
     async fn await_until_if_in_range(
         &self,
         da_height: &DaBlockHeight,
-        max_da_lag: &DaBlockHeight,
+        _max_da_lag: &DaBlockHeight,
     ) -> anyhow::Result<()> {
         #[cfg(feature = "relayer")]
         {
             if let Some(sync) = self.relayer_synced.as_ref() {
                 let current_height = sync.get_finalized_da_height()?;
                 anyhow::ensure!(
-                    da_height.saturating_sub(*current_height) <= **max_da_lag,
+                    da_height.saturating_sub(*current_height) <= **_max_da_lag,
                     "Relayer is too far out of sync"
                 );
                 sync.await_at_least_synced(da_height).await?;
@@ -100,7 +100,6 @@ impl RelayerPort for MaybeRelayerAdapter {
         }
         #[cfg(not(feature = "relayer"))]
         {
-            core::mem::drop(max_da_lag);
             anyhow::ensure!(
                 **da_height == 0,
                 "Cannot have a da height above zero without a relayer"

crates/metrics/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 pub mod core_metrics;
 pub mod graphql_metrics;

crates/services/consensus_module/bft/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 pub mod config;
 pub mod service;

crates/services/consensus_module/poa/src/lib.rs

@@ -1,5 +1,6 @@
 #![deny(unused_crate_dependencies)]
 #![deny(unused_must_use)]
+#![deny(warnings)]
 
 mod deadline_clock;
 mod sync;

crates/services/consensus_module/src/lib.rs

@@ -1,6 +1,7 @@
 //! Common traits and logic for managing the lifecycle of services
 #![deny(unused_crate_dependencies)]
 #![deny(missing_docs)]
+#![deny(warnings)]
 
 extern crate core;
 

crates/services/executor/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 mod config;
 

crates/services/importer/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 pub mod config;
 pub mod importer;

crates/services/producer/src/lib.rs

@@ -1,5 +1,6 @@
 #![deny(unused_crate_dependencies)]
 #![deny(unused_must_use)]
+#![deny(warnings)]
 
 pub mod block_producer;
 pub mod config;

crates/services/relayer/src/lib.rs

@@ -3,6 +3,7 @@
 #![deny(unused_crate_dependencies)]
 #![forbid(unsafe_code)]
 #![deny(missing_docs)]
+#![deny(warnings)]
 
 pub(crate) mod abi;
 pub(crate) mod config;

crates/services/src/lib.rs

@@ -1,6 +1,7 @@
 //! Common traits and logic for managing the lifecycle of services
 #![deny(unused_crate_dependencies)]
 #![deny(missing_docs)]
+#![deny(warnings)]
 
 mod service;
 mod state;

crates/services/sync/src/lib.rs

@@ -1,5 +1,6 @@
 #![deny(unused_crate_dependencies)]
 #![deny(missing_docs)]
+#![deny(warnings)]
 //! # Sync Service
 //! Responsible for syncing the blockchain from the network.
 

crates/services/txpool/src/lib.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 use fuel_core_types::{
     services::txpool::{

crates/storage/src/lib.rs

@@ -6,6 +6,7 @@
 
 #![deny(unused_crate_dependencies)]
 #![deny(missing_docs)]
+#![deny(warnings)]
 
 use fuel_core_types::services::executor::Error as ExecutorError;
 use std::io::ErrorKind;

crates/types/src/lib.rs

@@ -4,6 +4,7 @@
 
 #![deny(unused_crate_dependencies)]
 #![deny(missing_docs)]
+#![deny(warnings)]
 
 #[doc(no_inline)]
 pub use fuel_vm_private::{

xtask/src/main.rs

@@ -1,4 +1,5 @@
 #![deny(unused_crate_dependencies)]
+#![deny(warnings)]
 
 use clap::Parser;
 use commands::{