-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e-connector-tests): unify connector tests FE-860 #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and BurnerWalletConnector
Update pr-tests.yml Update pr-tests.yml Update pr-tests.yml refactor: Update PR tests workflow to use npx playwright for E2E tests
ci: debug undo . e2e: run in headless mode as it is faster ci: fix
This reverts commit f1e0d75.
nelitow
force-pushed
the
nj/feat/unify-connector-tests
branch
from
November 9, 2024 04:55
ba998ff
to
a2a78b1
Compare
arthurgeron
reviewed
Nov 10, 2024
arthurgeron
approved these changes
Nov 12, 2024
helciofranco
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the tests generic, with the idea of importing the tests needed for each connector, instead of rewriting them for every item on the connectors list.
This is in preparation for having the same test suite for all connectors.