Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add phantom as featured #179

Merged
merged 10 commits into from
Aug 8, 2024
Merged

feat: add phantom as featured #179

merged 10 commits into from
Aug 8, 2024

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Aug 6, 2024 •
edited
Loading

Phantom Wallet is now featured in the Solana wallet connectors list.
Previously, it required installation or accessing the “All Wallets” list to be found.

📷 Demo
Screenshot 2024-08-07 at 12 00 59

@helciofranco helciofranco self-assigned this Aug 6, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:35pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 72.67% 266 / 366
🔵 Statements 72.67% 266 / 366
🔵 Functions 53.33% 16 / 30
🔵 Branches 86.36% 19 / 22
File CoverageNo changed files found.
Generated in workflow #499

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #499

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 22 / 22
🔵 Statements 100% 22 / 22
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #499

arthurgeron
arthurgeron requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, but I've found two bugs:

  • It duplicates the Phantom option in Solana connector when Phantom Wallet is installed:
    CleanShot 2024-08-06 at 16 34 36

  • PR Audit check is failing

@helciofranco
Copy link
Member Author

Nice catch @arthurgeron I'll take a look on it

@helciofranco
Copy link
Member Author

@arthurgeron done, should be all set.

Now the phantom connector will be visible only if there's no phantom in the window.

Regarding the audit, it's a known issue in our repos right now and there's no resolution yet (that package haven't published a fix).

Ready for review again.

arthurgeron
arthurgeron previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LuizAsFight
LuizAsFight requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the same situation mentioned by @arthurgeron happen with trust and okx wallet as well?

@helciofranco
Copy link
Member Author

@LuizAsFight great question, that issue may affect those connectors too.

we can decide between two solutions here:

  1. fix for those connectors (okx and trust wallet)
  2. remove them and keep only phantom as featured

which option is better?

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Aug 7, 2024 •
edited
Loading

@helciofranco let's keep Trust and Phantom. okx can be removed from featured.

would be nice if we can also include Solflare

@helciofranco helciofranco enabled auto-merge (squash) August 7, 2024 16:54
arthurgeron
arthurgeron approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helciofranco helciofranco merged commit d175142 into main Aug 8, 2024
10 checks passed
@helciofranco helciofranco deleted the hf/feat/add-phantom-as-featured branch August 8, 2024 01:37
@fuel-service-user fuel-service-user mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@arthurgeron arthurgeron arthurgeron approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Assignees

@helciofranco helciofranco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include phantom wallet by default in solana connectors (even if you don't have it installed)
3 participants
@helciofranco @LuizAsFight @arthurgeron