Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Solana and WalletConnect Web3Modal conflicts #164

Merged
merged 27 commits into from
Jul 26, 2024
Merged

fix: Solana and WalletConnect Web3Modal conflicts #164

merged 27 commits into from
Jul 26, 2024

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Jul 18, 2024 •
edited
Loading

Patch Changes

  • Added a method to retrieve the actual account address that originated the predicate on Wallet Connect, allowing validation of whether a predicate originated from a specific EVM address.
  • Fixed issue where instances of Web3Modal from Wallet Connect and Solana would conflict between them, mixing listing of connectors, event listeners and address parsing (e.g. Solana receiving a connect event from WC and trying to calculate predicate address from an EVM address)
  • Fixed issue where Web3Modal would use a different Wagmi config instance, losing the reference to the required provider.
  • WalletConnect now recovers the last active connection as soon as possible, taking ~1 second instead of a couple (or more) seconds while waiting for provider startup and connection events.
  • Updated wagmi and @wagmi/core to 2.11.3
  • Updated @wagmi/connectors to 5.0.26

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 1:36pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024 •
edited
Loading

This PR is published in NPM with version 0.9.1-pr-164-1

@arthurgeron arthurgeron force-pushed the ag/feat/wallet-connect-predicate-to-account-address branch from 7f9b9a5 to e7a27c7 Compare July 18, 2024 23:09
@arthurgeron arthurgeron enabled auto-merge (squash) July 19, 2024 00:04
LuizAsFight
LuizAsFight requested changes Jul 19, 2024
View reviewed changes
.changeset/eight-bears-prove.md Outdated Show resolved Hide resolved
.changeset/fuel-labs-ci.md Outdated Show resolved Hide resolved
@LuizAsFight LuizAsFight changed the title feat: get evm address from a Wallet Connect connector instance feat(WalletConnect): add method currentEvmAccount to return connected ethereum account Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 72.37% 262 / 362
🔵 Statements 72.37% 262 / 362
🔵 Functions 53.33% 16 / 30
🔵 Branches 90.47% 19 / 21
File CoverageNo changed files found.
Generated in workflow #439

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #439

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 22 / 22
🔵 Statements 100% 22 / 22
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #439

@arthurgeron arthurgeron marked this pull request as draft July 19, 2024 19:36
@arthurgeron
feat: reinstantiate web3modal on wallet connect
4fce9e3 
necessary because solana connector also is dynamic and will replace state otherwise
@arthurgeron arthurgeron changed the title feat(WalletConnect): add method currentEvmAccount to return connected ethereum account fix: Solana and WalletConnect Web3Modal conflicts Jul 25, 2024
@arthurgeron arthurgeron marked this pull request as ready for review July 25, 2024 16:04
@arthurgeron arthurgeron enabled auto-merge (squash) July 26, 2024 22:10
@arthurgeron arthurgeron merged commit 4bdfc4c into main Jul 26, 2024
27 of 30 checks passed
@arthurgeron arthurgeron deleted the ag/feat/wallet-connect-predicate-to-account-address branch July 26, 2024 23:02
@fuel-service-user fuel-service-user mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurgeron @LuizAsFight