Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: automate component imports #21

Merged
merged 21 commits into from
Aug 9, 2023
Merged

refactor: automate component imports #21

merged 21 commits into from
Aug 9, 2023

Conversation

sarahschwartz
Copy link
Contributor

@sarahschwartz sarahschwartz commented Jul 24, 2023 •
edited
Loading

This PR:

  • updates the wallet and graphql repos to use the nav.json and components.json config files
  • adds a script to generate components based on the config and use them in the imports

@pedronauck
Copy link
Contributor

with this new pr I guess this one is not needed anymore, since we are moving to an SSG, by importing things directly we will have three-shaking and optimizations made by the framework so you don't need dynamic imports as we are doing right now

@sarahschwartz sarahschwartz self-assigned this Aug 3, 2023
@sarahschwartz sarahschwartz marked this pull request as ready for review August 3, 2023 22:06
pedronauck
pedronauck requested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@pedronauck pedronauck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve code inside the component.mjs file? Try to split more the algorithm using explicit functions, it's a bit harder to understand the code right now

pedronauck
pedronauck requested changes Aug 9, 2023
View reviewed changes
scripts/components.mjs Outdated Show resolved Hide resolved
@sarahschwartz sarahschwartz merged commit bbcc540 into master Aug 9, 2023
4 checks passed
@sarahschwartz sarahschwartz deleted the sarah/components branch August 11, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronauck pedronauck pedronauck approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio

Assignees

@sarahschwartz sarahschwartz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahschwartz @pedronauck