refactor(publisher): Remove PublishError in favor of anyhow::Result
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes PublishError in favor of bubbling pending unactionable errors to std when there is an error publishing any subject/payload. Given the focus of the Publish process, only dependent libraries or actionable errors should have an error signature.We can safely do this since it's all application code and we will be relying on our tracing for stack traces to implement certain actions after analyzing the errors. This makes our code more concise for the domain solution it solves.
Jurshsmith
requested review from
luizstacio,
pedronauck and
0xterminator
as code owners
Jurshsmith
changed the title
PublishError in favor of anyhow::ResultPublishError in favor of anyhow::Result
0xterminator
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes PublishError in favor of bubbling pending unactionable errors to
stdoutwhen there is an error publishing any subject/payload.Given the focus of the Publish process, only dependent libraries or actionable errors should have an error signature. We can safely do this since it's all application code and we will be relying on our tracing for stack traces to implement certain actions after analyzing the errors. This makes our code more concise for the domain solution it solves.
Closes DS-108