Add Cartographer3D V3 with Touch configuration #684
Conversation
We need to be able to override some settings for `[bed_mesh]` so the include in `user_templates/printer.cfg` is placed after the bed mesh definitions and not in the probe section. Cartographer3D V3 doesn't touch the bed with the nozzle except for the `CARTOGRAPHER_TOUCH` command. Therefore we need to pay attention to the nozzle temperature for that. But not for all the other actions like homing or quad gantry leveling or some such. The documentation for Cartographer3D advises against an adaptive bed mesh and the full bed mesh will be fast enough in most cases, so we deactivated the adaptive bed mesh if a Cartographer3D probe is used.
typetetris
force-pushed
the
cartographer_touch
branch
from
4a66521 to
3774824
Compare
|
Hello, thanks for the PR! It's a good starting point. But there's a couple of changes that are needed to align it more with current Klippain logic and simplify the code. So the first thing would be to use the ACTIVATE/DEACTIVATE_PROBE to manage the temperature limit, etc... and remove the Regarding your decisions, here are my comments:
This can be removed since the changes in bed_mesh are pretty anecdotal (they are not needed for it to works) and could be placed in the
Yes you are right on this and I've got now way to manage it currently... So I will have to think about a refactor to make it better. In the meantime I would prefer that you use the ACTIVATE/DEACTIVATE_PROBE, even if not perfect, but if the START_PRINT sequence is well defined, it shouldn't be a problem.
I've got no problem with that. Maybe we can do the same with the beacon later on as well.
Yes, this would definitely be better, but it would also be a breaking change for a lot of people unfortunately... So maybe we can move this PR to the develop branch, to allow merging also the beacon contact, move it to |
Regarding using the Should I include rehoming the z axis in the |
No, this is not necessary. In fact, it is necessary for all probes to do this: after a QGL, you have to do a Z home to take a new, more correct height reference. But in Klippain, to avoid wasting time and doing too many Z homeings during the START_PRINT, especially for probes that need to have a lower temperature like TAP, the start print sequences are made by taking this into account automatically and the Z homeings are done most of the time only once, just before taking the final Z offset. So there's no need to add specific things, as it's already taken into account later :) |
|
@typetetris We've done something a litle bit different and more transparent in klippain-chocolate. We use carto like a voron tap-probe |
This adds configuration for a Cartographer 3D with Touch enabled and an adxl accelerometer.
Please give it a thorough review, as its my first work on such stuff, which I didn't do only for myself.
Reasons for some of the decisions I made:
We need to be able to override some settings for
[bed_mesh]so the include inuser_templates/printer.cfgis placed after the bed mesh definitions and notin the probe section.
Cartographer3D V3 doesn't touch the bed with the nozzle except for the
CARTOGRAPHER_TOUCHcommand. Therefore we need to pay attention to the nozzle temperature for that. But not for all the other actions likehoming or quad gantry leveling or some such.
The documentation for Cartographer3D advises against an adaptive bed mesh and the full bed mesh will
be fast enough in most cases, so we deactivated
the adaptive bed mesh if a Cartographer3D probe
is used. Maybe this should be configurable? Tell me, and I will alter it.
Also, what do you think about
variable_cartographer_touch_max_probing_tempmaybe I should simply usevariable_safe_extruder_tempinstead?This would make it easier and more backwards compatible. But for now I took inspiration
from
variable_tap_max_probing_temp.