Use underscored var names

FriendsOfCake · Apr 17, 2023 · 049db99 · 049db99
1 parent 6ba5ee1
commit 049db99
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Action/LookupAction.php b/src/Action/LookupAction.php
@@ -63,12 +63,12 @@ protected function _getFindConfig(): array
         $columns = $this->_table()->getSchema()->columns();
         $config = (array)$this->getConfig('findConfig');
 
-        $idField = $request->getQuery('keyField') ?: $request->getQuery('id');
+        $idField = $request->getQuery('key_field') ?: $request->getQuery('id');
         if (in_array($idField, $columns)) {
             $config['keyField'] = $idField;
         }
 
-        $valueField = $request->getQuery('valueField') ?: $request->getQuery('value');
+        $valueField = $request->getQuery('value_field') ?: $request->getQuery('value');
         if (in_array($valueField, $columns)) {
             $config['valueField'] = $valueField;
         }

diff --git a/tests/TestCase/Action/LookupActionTest.php b/tests/TestCase/Action/LookupActionTest.php
@@ -97,7 +97,7 @@ function () {
             '3rd post' => '3',
         ];
 
-        $this->get('/blogs/lookup.json?keyField=name&valueField=id');
+        $this->get('/blogs/lookup.json?key_field=name&value_field=id');
         $this->assertEvents(['beforeLookup', 'afterLookup', 'beforeRender']);
         $this->assertNotNull($this->viewVariable('viewVar'));
         $this->assertNotNull($this->viewVariable('blogs'));