-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sisyphus Revision Part 2: Full Donate Revision #235
base: main
Are you sure you want to change the base?
Conversation
6e5f860
to
2b4cb19
Compare
|
Maybe it can be added later, but it is not good to over-direct the user in this way. There should always be at least a text field.
Considering the invisibility of the current donation system, it is not right to call something on the menu invisible. I did it this way on purpose because I thought maybe it wouldn't be desirable for it to be more visible.
Probably yes a gap would be nice.
This can be done, but I think it is better for one to see the full explanation. There is a similar feature on the sponsor page, by clicking on the relevant sections, the donate modal is opened. |
2b4cb19
to
fcfbd20
Compare
I didn't mean that we should remove the text field, just add new buttons. It's easier to click a button than to write something - this is also why tip in restaurants usually have predefined options.
Since kicad and blender has it I don't think it would be that bad if we also have it :)
I think it is important to make it simple to donate, reading a wall of text is tiresome in my opinion |
I will also add a later PR. It will even be better than the others because mostly the buttons are not interactive, I plan to be interactive. Of course, if this PR is accepted, they will come.
Depending on the reactions, I plan to do it in future PRs.
Since it was a task that required editorial things, I didn't want this PR to wait any longer just for that reason. #221 This PR of mine is pending just for editorial reasons. I plan to do something about this in future PRs. The system added here lays a very good foundation. Anything desired can be done. But I didn't want to fill it too much. |
fcfbd20
to
a223e02
Compare
I agree the sponsors page is getting big and the donation part could go elsewhere, and having it as a kind of "pop-up" like that, why not, it's cool. But it also needs to appear on the "thank you" page that the user gets after downloading, but I think we don't want that to pop up automatically after download. Ideally it would have two modes, one "pop up" and one embedded inside a page, is that doable? |
That's the way it is now, isn't it? The existing thank you page system has not been changed. I made minimal changes to most things. This needs to be changed? So should this be opened instead of the thank you page? I think the current system makes sense. A button that will open the donate modal can be added to the desired page, and donations can be made for the relevant level by pressing the added titles on the modified sponsor page. This works better than an alternative included in the page because exceptions are confusing. However, there is a menu on the thank-you page and there will be a donate button in this menu, that is probably the best place to appear. Buttons to open this modal may be added in future PRs. |
This transforms it from the current situation to a very very good shape. The things that can be seen as a problem remain very small as well as the benefits it brings. I think it makes more sense to solve problems after Merge. |
Ton Roosendaal devotes 1 minute of his 30-minute speech at the Blender conference to this slide.
I had made this suggestion before, but ultimately decided on a system like this. This system is the same as that used for KiCAD. However, unlike them, I do not use ifram and this provides a better view. All articles have been reused with very minor corrections. It uses entirely what Bootstrap offers. There is no design addition. It can still be modified and added to, but I think it is quite acceptable as is.
I also added another very nice feature, thanks to this feature, you can call the fields in the modal as desired within the site.
For a better look, you can look here.