Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sisyphus Revision Part 2: Full Donate Revision #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Reqrefusion
Copy link
Member

resim
Ton Roosendaal devotes 1 minute of his 30-minute speech at the Blender conference to this slide.

I had made this suggestion before, but ultimately decided on a system like this. This system is the same as that used for KiCAD. However, unlike them, I do not use ifram and this provides a better view. All articles have been reused with very minor corrections. It uses entirely what Bootstrap offers. There is no design addition. It can still be modified and added to, but I think it is quite acceptable as is.

I also added another very nice feature, thanks to this feature, you can call the fields in the modal as desired within the site.

For a better look, you can look here.

resim
resim
resim
resim
resim

@hyarion
Copy link
Contributor

hyarion commented Jan 20, 2025

  • in this version the user has to enter a value, why not include predefined values as buttons like blender and kicad has?
  • the donate button is quite invisible, could it have a background that stands out a bit like on blender and kicad's sites?
  • The ♡ is a bit too close to the text in my opinion, how about adding a small space between them?
  • the UI is really text heavy to describe levels. Godot uses predefined values and describes what you get when you click those, check it out here: https://fund.godotengine.org/

@Reqrefusion
Copy link
Member Author

in this version the user has to enter a value, why not include predefined values as buttons like blender and kicad has?

Maybe it can be added later, but it is not good to over-direct the user in this way. There should always be at least a text field.

the donate button is quite invisible, could it have a background that stands out a bit like on blender and kicad's sites?

Considering the invisibility of the current donation system, it is not right to call something on the menu invisible. I did it this way on purpose because I thought maybe it wouldn't be desirable for it to be more visible.

The ♡ is a bit too close to the text in my opinion, how about adding a small space between them?

Probably yes a gap would be nice.

the UI is really text heavy to describe levels. Godot uses predefined values and describes what you get when you click those, check it out here: https://fund.godotengine.org/

This can be done, but I think it is better for one to see the full explanation. There is a similar feature on the sponsor page, by clicking on the relevant sections, the donate modal is opened.

@hyarion
Copy link
Contributor

hyarion commented Jan 20, 2025

in this version the user has to enter a value, why not include predefined values as buttons like blender and kicad has?

Maybe it can be added later, but it is not good to over-direct the user in this way. There should always be at least a text field.

I didn't mean that we should remove the text field, just add new buttons. It's easier to click a button than to write something - this is also why tip in restaurants usually have predefined options.

the donate button is quite invisible, could it have a background that stands out a bit like on blender and kicad's sites?

Considering the invisibility of the current donation system, it is not right to call something on the menu invisible. I did it this way on purpose because I thought maybe it wouldn't be desirable for it to be more visible.

Since kicad and blender has it I don't think it would be that bad if we also have it :)

the UI is really text heavy to describe levels. Godot uses predefined values and describes what you get when you click those, check it out here: https://fund.godotengine.org/

This can be done, but I think it is better for one to see the full explanation. There is a similar feature on the sponsor page, by clicking on the relevant sections, the donate modal is opened.

I think it is important to make it simple to donate, reading a wall of text is tiresome in my opinion

@Reqrefusion
Copy link
Member Author

Reqrefusion commented Jan 20, 2025

I didn't mean that we should remove the text field, just add new buttons. It's easier to click a button than to write something - this is also why tip in restaurants usually have predefined options.

I will also add a later PR. It will even be better than the others because mostly the buttons are not interactive, I plan to be interactive. Of course, if this PR is accepted, they will come.

Since kicad and blender has it I don't think it would be that bad if we also have it :)

Depending on the reactions, I plan to do it in future PRs.

I think it is important to make it simple to donate, reading a wall of text is tiresome in my opinion

Since it was a task that required editorial things, I didn't want this PR to wait any longer just for that reason. #221 This PR of mine is pending just for editorial reasons. I plan to do something about this in future PRs.

The system added here lays a very good foundation. Anything desired can be done. But I didn't want to fill it too much.

@yorikvanhavre
Copy link
Member

I agree the sponsors page is getting big and the donation part could go elsewhere, and having it as a kind of "pop-up" like that, why not, it's cool. But it also needs to appear on the "thank you" page that the user gets after downloading, but I think we don't want that to pop up automatically after download. Ideally it would have two modes, one "pop up" and one embedded inside a page, is that doable?

@Reqrefusion
Copy link
Member Author

Reqrefusion commented Jan 22, 2025

I agree the sponsors page is getting big and the donation part could go elsewhere, and having it as a kind of "pop-up" like that, why not, it's cool. But it also needs to appear on the "thank you" page that the user gets after downloading, but I think we don't want that to pop up automatically after download. Ideally it would have two modes, one "pop up" and one embedded inside a page, is that doable?

That's the way it is now, isn't it? The existing thank you page system has not been changed. I made minimal changes to most things. This needs to be changed? So should this be opened instead of the thank you page? I think the current system makes sense.

A button that will open the donate modal can be added to the desired page, and donations can be made for the relevant level by pressing the added titles on the modified sponsor page.

This works better than an alternative included in the page because exceptions are confusing. However, there is a menu on the thank-you page and there will be a donate button in this menu, that is probably the best place to appear. Buttons to open this modal may be added in future PRs.

@Reqrefusion
Copy link
Member Author

This transforms it from the current situation to a very very good shape. The things that can be seen as a problem remain very small as well as the benefits it brings. I think it makes more sense to solve problems after Merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants