Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Vue compiler in @snowpack/plugin-vue configurable #3854

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sebastiandittrich
Copy link

Changes

This PR adds the possibility to configure the vue compiler in @snowpack/plugin-vue.

Before:

// snowpack.config.mjs
export default {
  plugins: [
    ['@snowpack/plugin-vue', { /* No possibility to pass configuration options to the vue compiler */ }]
  ]
}

After:

// snowpack.config.mjs
export default {
  plugins: [
    ['@snowpack/plugin-vue', { compilerOptions: { isCustomElement: (tag) => tag.startsWith('lit-') } }]
  ]
}

Testing

This change was tested locally in my existing setup. It worked, and should not be breaking anything else, since it's just one line of code added, without side effects.

Docs

plugins/plugin-vue/README.md was updated accordingly.

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2022

⚠️ No Changeset found

Latest commit: 6e58a93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/GYvuVazZrVLzBF1jQVmpsvbLjhfV
✅ Preview: https://snowpack-git-fork-sebastiandittrich-plugin-vue-c-d03885-pikapkg.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant