Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 87 #119

Merged
merged 8 commits into from
Sep 29, 2022
Merged

issue 87 #119

merged 8 commits into from
Sep 29, 2022

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Sep 28, 2022

A lot of misc cleanup after some feedback from the core team. Idea is to simplify and get this ready for public consumption.

  • cleaned up env sample file and added comments
  • switched to inferring graphql url from projectid since the rest of the URL is from a known format listed on Sanity's website
  • updated readme with clarifications, updates since we're no longer using shirts, improved diagram

I think the readme will need one more pass after this, but this is a step in the right direction.

@vercel
Copy link

vercel bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-sanity-fe ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 3:46PM (UTC)

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Burnett2k
Copy link
Member Author

closes #87

@Burnett2k Burnett2k closed this Sep 29, 2022
@Burnett2k Burnett2k reopened this Sep 29, 2022
@Burnett2k Burnett2k merged commit de60953 into main Sep 29, 2022
@Burnett2k Burnett2k deleted the issue-87 branch September 29, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants