Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TraceDetail tests and update test IDs #189

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Re-enable TraceDetail tests and update test IDs #189

merged 1 commit into from
Nov 20, 2023

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Nov 19, 2023 •
edited
Loading

In a previous PR, Trace Detail Tests were incorrectly skipped. This PR restores those tests and updates the test IDs.

Current Coverage

image

Closes #188

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2023

⚠️ No Changeset found

Latest commit: 3a72cfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

carbonrobot
carbonrobot commented Nov 19, 2023
View reviewed changes
packages/webui/src/components/ui/TraceDetail.test.tsx
);
expect(body).toBeVisible();
expect(body.getAttribute('data-content-type')).toBe(contentType);
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now use the same component for all code display, so this test is modified so that it checks that the correct content type was passed to the component instead of checking for the specific content components (which no longer exist)

carbonrobot
carbonrobot commented Nov 19, 2023
View reviewed changes
packages/webui/src/components/ui/TraceDetail.test.tsx

expect(body).not.toBeInTheDocument();
expect(tab).toHaveAttribute('disabled');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer remove the content from the DOM, we disable the Tab so it can not be selected

kgpax
kgpax approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@kgpax kgpax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only remaining missing coverage is:

image

Would be useful to add the tests over this in a future PR, so that we have something to check for any regressions.

@carbonrobot carbonrobot mentioned this pull request Nov 20, 2023
Open
@carbonrobot carbonrobot merged commit f8b8ef7 into main Nov 20, 2023
1 check passed
@carbonrobot carbonrobot deleted the test/re-enable-trace-detail branch November 20, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpax kgpax kgpax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reinstate and fix unit tests for TraceDetails.tests.tsx
2 participants
@carbonrobot @kgpax